The last changes that has been introduced by nikitakit in the unification of the Translate, Rotate and Scale tools into the Normal tool still having some things to fix. The current master version allows to reach the null state tool when you change the layer selection. This null tool shouldn't be reached never because it cannot have options. It was the old Normal tool.
I asked him to fix the code to return to normal tool when the layer selection changes instead of return to the null tool.
The changes that he has made are in the nikitakit_ducks branch and they works as expected.
But before apply to master I've noticed that it is possible to continue going to null state by pressing the STOP button or the ESCAPE key.
Fix those last bugs is very easy, but I would like to do it right.
This is the chart for the current tool event handling:
Code:
Layer Selection STOP button STOP button press
change effect status or ESC press
================================================================
Smooth : none disabled -
Mirror : none disabled -
Width : none enabled null tool
BLine : normal tool enabled reset
Circle : normal tool enabled null tool
Rectangle: normal tool enabled null tool
Star : normal tool enabled null tool
Gradient: normal tool enabled null tool
Polygon : normal tool enabled reset (doesn't refresh)
Text : normal tool enabled null tool
Draw : none enabled null tool
Fill : normal tool enabled null tool
EyeDrop : normal tool enabled null tool
Zoom : none enabled null tool
Sketch : none enabled null tool
As you can see there are some tools that still allowing to reach the null tool after pressing the STOP button.
I have the followings doubts:
1) When you change the layer selection some layers return to Normal tool and some other don't. Why? Which one should do that and which one don't and for which reason?
2) The STOP button is obviously a reason to leave the current tool and reach the normal tool. Should be disabled in some tools? why?
3) It seems that the BLine tool was born with the STOP button enabled but used to reset the bline creation. For that usage it is already a button in the Tool Option panel (the clean icon). It is worth to keep it or can the STOP button allow to return to Normal tool? Same comments to Polygon.
I would like to listen users opinion on that.
-G
_________________
Synfig needs your help!
Developers, packagers, bug testers, translators, artists, web developers, wiki writers... you
can contribute!
